Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Declare the plugin compatible with the Content Security Policy sent by GLPI.
Searches for inline event handlers,
javascript:URLs,<script>tags printed from PHP or created from JavaScript,on_changeandon*option keys and deprecated confirmation helpers returned no hit in the plugin code, so only'csp_compliant' => trueis added toplugin_version_oauthimap().Blocked by
PLUGIN_OAUTHIMAP_MIN_GLPI) must be raised to the first CSP-enabled 11.0 release before merging. This PR does not change it.Checklist before requesting a review
Description
Manual test checklist
Keep the browser console open: a CSP violation is reported as
Refused to execute inline event handlerorRefused to execute inline script.